generated from mwc/lab_dice
Add assessment
This commit is contained in:
16
assessment.md
Normal file
16
assessment.md
Normal file
@@ -0,0 +1,16 @@
|
||||
# Dice Lab Assessment
|
||||
|
||||
Everything works as expected. Nice work!
|
||||
|
||||
## Checkpoint 1
|
||||
Looks good. I like the "different" methods :)
|
||||
|
||||
## Checkpoint 2
|
||||
The content of your docstrings looks good. However, most are above their function
|
||||
rather than inside it. This technically works, but defeats some of the purpose of
|
||||
docstrings, as there are automated tools that use them and expect to find them in
|
||||
the right place.
|
||||
|
||||
## Checkpoint 3
|
||||
Your methods for finding full house and the straights are clever. Between small
|
||||
straight and large straight I can see you refining the algorithm.
|
||||
Reference in New Issue
Block a user