tnaber
/
lab_dice
generated from mwc/lab_dice
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add assessment

This commit is contained in:
Chris Proctor 2024-03-03 11:57:07 -05:00
parent 2a28d355df
commit 2a56bc667e
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
assessment.md Normal file
View File

@ -0,0 +1,16 @@
# Dice Lab Assessment
Everything works as expected. Nice work!
## Checkpoint 1
Looks good. I like the "different" methods :)
## Checkpoint 2
The content of your docstrings looks good. However, most are above their function
rather than inside it. This technically works, but defeats some of the purpose of
docstrings, as there are automated tools that use them and expect to find them in
the right place.
## Checkpoint 3
Your methods for finding full house and the straights are clever. Between small
straight and large straight I can see you refining the algorithm.