generated from mwc/lab_dice
821 B
821 B
Dice Lab Assessment
Everything works as expected. Nice work!
Checkpoint 1
Checking the endpoints of the range (e.g. listOfFaces[0] == listOfFaces[1] and listOfFaces[0] == listOfFaces[2]
was a clever way to accomplish this.
Checkpoint 2
The content of your docstrings looks good. However, most are above their function rather than inside it. This technically works, but defeats some of the purpose of docstrings, as there are automated tools that use them and expect to find them in the right place.
Checkpoint 3
Looks good. Just looking at your code for small straight, I wasn't sure it was correct,
so I wrote a few simple tests in test_small_straight.py
. Everything works :)
Comments
Thanks for thoughtful log messages. Indeed, D&D and other games are often excellent contexts for OOP.