From 501e223a9af34235f066d7fd58b2a7c6669b5f22 Mon Sep 17 00:00:00 2001 From: Chris Proctor Date: Sat, 2 Mar 2024 20:01:16 -0500 Subject: [PATCH] Add assessment --- assessment.md | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 assessment.md diff --git a/assessment.md b/assessment.md new file mode 100644 index 0000000..552c2a5 --- /dev/null +++ b/assessment.md @@ -0,0 +1,26 @@ +# Dice Lab Assessment + +Checkpoints 1 and 2 look good. Checkpoint 3 doesn't appear to be done--I can come +back to this if you finish this up (or just need to `mwc submit`) + +## Checkpoint 1 + +Using Counter was effective, although `is_three_of_a_kind` +fails with [1, 1, 1, 1, 1]. You could simplify further with +some additional idiomatic python: + +``` +def is_three_of_a_kind(self): + return max(Counter(self.faces())) >= 3 +``` + +`is_four_of_a_kind` has a similar bug. + +## Checkpoint 2 +The content of your docstrings looks good. However, most are above their function +rather than inside it. This technically works, but defeats some of the purpose of +docstrings, as there are automated tools that use them and expect to find them in +the right place. + +## Checkpoint 3 +Not done.