generated from mwc/lab_dice
Add assessment
This commit is contained in:
parent
873d398094
commit
f7194607d6
|
@ -1,4 +1,17 @@
|
||||||
# Dice Lab Assessment
|
# Dice Lab Assessment
|
||||||
|
|
||||||
Everything works as expected. Your docstrings were nice, and your use of Counter
|
Everything works as expected. Nice work!
|
||||||
was effective for three/four of a kind. Nice work!
|
|
||||||
|
## Checkpoint 1
|
||||||
|
|
||||||
|
Nice work! I hope you see the benefit of the more concise and Pythonic approach.
|
||||||
|
|
||||||
|
## Checkpoint 2
|
||||||
|
The content of your docstrings looks good.
|
||||||
|
|
||||||
|
## Checkpoint 3
|
||||||
|
Nice work implementing all the goals. I'm guessing you felt there might be a
|
||||||
|
better implementation of small straight. One possibility would be to use a
|
||||||
|
[set](https://docs.python.org/3/tutorial/datastructures.html#sets), which
|
||||||
|
crucially doesn't allow duplicates, and which supports set operations like
|
||||||
|
intersection.
|
||||||
|
|
Loading…
Reference in New Issue